linux-kernel - Re: [PATCH] nfs: fix kernel warning when removing proc entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140816175653.GA3884@gmail.com>
Date:	Sat, 16 Aug 2014 20:56:53 +0300
From:	Dan Aloni <dan@...nelim.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Stanislav Kinsbursky <skinsbursky@...allels.com>
Subject: Re: [PATCH] nfs: fix kernel warning when removing proc entry

On Thu, Aug 14, 2014 at 03:49:39PM -0700, Cong Wang wrote:
Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  fs/nfs/client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 1c5ff6d..1c57202 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -1429,7 +1429,7 @@ void nfs_fs_proc_net_exit(struct net *net)
>  
>  	remove_proc_entry("volumes", nn->proc_nfsfs);
>  	remove_proc_entry("servers", nn->proc_nfsfs);
> -	remove_proc_entry("fs/nfsfs", NULL);
> +	remove_proc_entry("nfsfs", net->proc_net);
>  }

nfs_fs_proc_net_init() has:

error_1:
        remove_proc_entry("fs/nfsfs", NULL);

I think this needs fixing too, for consistency.

-- 
Dan Aloni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/