linux-kernel - Re: [PATCH] [RFC] cgroup: reject cgroup names with non-printing characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140817134159.GE7679@mtj.dyndns.org>
Date:	Sun, 17 Aug 2014 09:41:59 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Alban Crequy <alban.crequy@...labora.co.uk>
Cc:	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
	Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH] [RFC] cgroup: reject cgroup names with non-printing
 characters

Hello, Alban.

Sorry about the delay.

On Mon, Jul 21, 2014 at 04:11:56PM +0100, Alban Crequy wrote:
> @@ -4387,6 +4401,11 @@ static int cgroup_mkdir(struct kernfs_node *parent_kn, const char *name,
>  	struct kernfs_node *kn;
>  	int ssid, ret;
>  
> +	/* do not create cgroups with bad names */
> +	ret = cgroup_is_used_badchars(name);
> +	if (ret)
> +		return ret;

Let's just reject '\n'.  That should give us a way to parse the path
correctly and I don't want to put more-than-necessary interpretation
on the path string.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/