linux-kernel - Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F1E1EA.8060708@gmail.com>
Date:	Mon, 18 Aug 2014 13:22:18 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Vivek Gautam <gautam.vivek@...sung.com>
CC:	Kukjin Kim <kgene.kim@...sung.com>, Felipe Balbi <balbi@...com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Kamil Debski <k.debski@...sung.com>,
	Mark Brown <broonie@...aro.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-samsung-soc@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote:
> On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote:
>> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz 
>> <b.zolnierkie@...sung.com> wrote
> 
>> There's one thing that I would want to comment here, since we don't have any 
>> new usb-phy driver for S3C64XX,
>> so we can't simply remove this entire driver.
>> I have posted my patch-series [1], which does cleanup while keeping the 
>> support for S3C64XX.
> 
> AFAIK S3C64XX code from drivers/usb/phy/phy-samsung-usb2.c has
> never been used as this platform still uses its own code from
> arch/arm/mach-s3c64xx/setup-usb-phy.c (there are no users in
> the kernel tree of either s3c64xx-usb2phy platform device or
> "samsung,s3c64xx-usb2phy" DT compatible) .  Therefore I think
> that the entire drivers/usb/phy/phy-samsung-usb2.c driver
> should be removed (somebody with the hardware can as well add
> S3C64XX support to the new drivers/phy/phy-samsung-usb2.c
> driver and port the platform to use it).
> 

I agree with removal of this driver. As Bart said, it is not used for
S3C64xx at all. The platform was supposed to be moved to this driver,
but that never happened. In fact, I already have a patch adding support
for S3C64xx to the new driver.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/