linux-kernel - Re: [PATCH 1/1] mmc: core: Use regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140818131832.GS14537@sirena.org.uk>
Date:	Mon, 18 Aug 2014 08:18:32 -0500
From:	Mark Brown <broonie@...nel.org>
To:	Tim Kryger <tim.kryger@...il.com>
Cc:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Chris Ball <chris@...ntf.net>,
	Seungwon Jeon <tgih.jun@...sung.com>,
	Haijun Zhang <Haijun.Zhang@...escale.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Yuvaraj Kumar C D <yuvaraj.cd@...il.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mmc: core: Use regulator_get_voltage() if OCR mask
 is empty.

On Sun, Aug 17, 2014 at 10:11:30AM -0700, Tim Kryger wrote:
> On Fri, Aug 15, 2014 at 3:29 PM, Mark Brown <broonie@...nel.org> wrote:

> > Nobody has written suitable code, and please bear in mind that even if
> > the code is written there will probably be cases where it's too
> > expensive for whatever reason so Javier's change is going to be needed.

> I fail to see how replicating similar logic at all current
> regulator_list_voltage call sites would be any more efficient than
> handling this directly in regulator core.

If you feel like writing a helper function that would be fine but
list_voltage() can't be doing expensive talking to the hardware
operations - it needs to be something people can be comfortable calling
a lot.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)