linux-kernel - Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F189A0.8090304@hitachi.com>
Date:	Mon, 18 Aug 2014 14:05:36 +0900
From:	Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com>
To:	emilne@...hat.com
Cc:	Hannes Reinecke <hare@...e.de>, linux-scsi@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	yrl.pp-manager.tt@...achi.com, linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>,
	Doug Gilbert <dgilbert@...erlog.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Christoph Hellwig <hch@....de>
Subject: Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command()

Hi Ewan,

Thank you for your review.

(2014/08/16 0:05), Ewan Milne wrote:
> On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote:
>> All bytes in CDB should be output after linebuf is filled because
>> "[%s] CDB: %s\n" message is output many times in loop.
>>
>> Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com>
>> Cc: Hannes Reinecke <hare@...e.de>
>> Cc: Doug Gilbert <dgilbert@...erlog.com>
>> Cc: Martin K. Petersen <martin.petersen@...cle.com>
>> Cc: Christoph Hellwig <hch@....de>
>> Cc: "James E.J. Bottomley" <JBottomley@...allels.com>
>> Cc: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
>> ---
>>   drivers/scsi/constants.c |    3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c
>> index 9c38b8d..5956d4d 100644
>> --- a/drivers/scsi/constants.c
>> +++ b/drivers/scsi/constants.c
>> @@ -413,9 +413,8 @@ void __scsi_print_command(struct scsi_device *sdev, const char *prefix,
>>
>>   		hex_dump_to_buffer(cdb + i, linelen, 16, 1,
>>   				   linebuf, sizeof(linebuf), false);
>> -		sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n",
>> -			    prefix, linebuf);
>>   	}
>> +	sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n", prefix, linebuf);
>>   }
>>   EXPORT_SYMBOL(__scsi_print_command);
>
> This doesn't look right -- In Hannes' tree what the code is doing is
> printing out a separate line for each 16 bytes of the CDB.  You change
> will cause only the last (partial?) 16 bytes to be printed.

Ah, that's true. We should not apply this patch.

Thanks,
Yoshihiro YUNOMAE

-- 
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@...achi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/