lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Aug 2014 09:00:06 +0000 From: "Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com> To: "shengjiu.wang@...escale.com" <shengjiu.wang@...escale.com> CC: Lars-Peter Clausen <lars@...afoo.de>, "lgirdwood@...il.com" <lgirdwood@...il.com>, "broonie@...nel.org" <broonie@...nel.org>, "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>, "nicoleotsuka@...il.com" <nicoleotsuka@...il.com>, "shc_work@...l.ru" <shc_work@...l.ru>, "Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>, "xobs@...agi.com" <xobs@...agi.com>, "arnd@...db.de" <arnd@...db.de>, "sfr@...b.auug.org.au" <sfr@...b.auug.org.au>, "timur@...i.org" <timur@...i.org>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC config SND_SOC_FSL_SAI tristate "Synchronous Audio Interface (SAI) module support" select REGMAP_MMIO - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n + select SND_SOC_IMX_PCM_DMA select SND_SOC_GENERIC_DMAENGINE_PCM help Say Y if you want to add Synchronous Audio Interface (SAI) @@ -25,7 +25,7 @@ config SND_SOC_FSL_SAI config SND_SOC_FSL_SSI tristate "Synchronous Serial Interface module support" - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n + select SND_SOC_IMX_PCM_DMA select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && (MXC_TZIC || MXC_AVIC) select REGMAP_MMIO help @@ -37,7 +37,7 @@ config SND_SOC_FSL_SSI config SND_SOC_FSL_SPDIF tristate "Sony/Philips Digital Interface module support" select REGMAP_MMIO - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n + select SND_SOC_IMX_PCM_DMA select SND_SOC_IMX_PCM_FIQ if SND_IMX_SOC != n && (MXC_TZIC || MXC_AVIC) help Say Y if you want to add Sony/Philips Digital Interface (SPDIF) @@ -48,7 +48,7 @@ config SND_SOC_FSL_SPDIF config SND_SOC_FSL_ESAI tristate "Enhanced Serial Audio Interface (ESAI) module support" select REGMAP_MMIO - select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n + select SND_SOC_IMX_PCM_DMA help Say Y if you want to add Enhanced Synchronous Audio Interface (ESAI) support for the Freescale CPUs. @@ -76,6 +76,7 @@ config SND_SOC_FSL_ASOC_CARD config SND_SOC_IMX_PCM_DMA tristate + depends on SND_IMX_SOC select SND_SOC_GENERIC_DMAENGINE_PCM config SND_SOC_IMX_AUDMUX Thanks, BRs Xiubo > -----Original Message----- > From: Shengjiu Wang [mailto:shengjiu.wang@...escale.com] > Sent: Tuesday, August 19, 2014 4:21 PM > To: Xiubo Li-B47053 > Cc: Lars-Peter Clausen; lgirdwood@...il.com; broonie@...nel.org; > perex@...ex.cz; tiwai@...e.de; nicoleotsuka@...il.com; shc_work@...l.ru; > Estevam Fabio-R49496; xobs@...agi.com; arnd@...db.de; sfr@...b.auug.org.au; > timur@...i.org; alsa-devel@...a-project.org; linuxppc-dev@...ts.ozlabs.org; > linux-kernel@...r.kernel.org > Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence > of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA > > On Tue, Aug 19, 2014 at 04:13:15PM +0800, Xiubo Li-B47053 wrote: > > > Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove > dependence > > > of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA > > > > > > On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: > > > > On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > > > > >Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the > > > following > > > > >error: > > > > > > > > > > sound/built-in.o: In function `fsl_sai_probe': > > > > >>>fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init' > > > > > sound/built-in.o: In function `fsl_esai_probe': > > > > >>>fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init' > > > > > > > > > >Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' > which is > > > > >defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but it > > > depends > > > > >on SND_IMX_SOC, if SND_IMX_SOC=n, then SND_SOC_IMX_PCM_DMA will not be > > > > >selected. > > > > >So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. > > > > > > > > > >Reported-by: kbuild test robot <fengguang.wu@...el.com> > > > > >Signed-off-by: Shengjiu Wang <shengjiu.wang@...escale.com> > > > > > > > > Those if conditions where just added[1] by Arnd to avoid other build > > > > failures. So just removing them again makes little sense. > > > > > > > > As far as I can see imx_pcm_dma_init() should be stubbed out when > > > > SND_SOC_IMX_PCM_DMA is not selected. So what's going on here? > > > > > > > > [1] > > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ff40 > > > 260f79dc0436604452bccd449bffd25ebafb > > > > > > > Lars-Peter Clausen & Arnd > > > > > > The purpose of Arnd's patch is same with me, which is to resolve the build > > > error when SND_SOC_IMX_PCM_DMA=m & SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=y, the > > > error is "undefined reference to `imx_pcm_dma_init'". > > > But Arnd's patch didn't involve this situation that SND_IMX_SOC=n & > > > SND_SOC_IMX_PCM_DMA=m. > > > > > > Currently I think out a solution for this issue is to change > > > > > > select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n > > > > > > to > > > > > > depends on SND_SOC_IMX_PCM_DMA != m > > > > > > How do you think about this? > > > > > > > What will happen if to build both SAI/ESAI and IMX_PCM_DMA as modules at the > same > > time ? > > > > Thanks, > > > > BRs > > Xiubo > > I didn't find error/warning when SAI/ESAI and IMX_PCM_DMA are as modules. The > build is successful. > > > > > > > > best regards > > > Wang shengjiu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists