linux-kernel - Re: [PATCH] gpio-lynxpoint: enable input sensing in resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2014 13:44:27 +0300
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:	Linus <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio-lynxpoint: enable input sensing in resume

On 08/19/2014 01:22 PM, Mika Westerberg wrote:
> On Tue, Aug 19, 2014 at 01:30:28PM +0300, Mathias Nyman wrote:
>> It appears that input sensing bit might be reset during
>> suspend/resume. Set input sensing again for all requested gpios
>> in resume
>>
>> Tested-by: Jerome Blin <jerome.blin@...el.com>
>> Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
>> ---
>>  drivers/gpio/gpio-lynxpoint.c | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
>> index ff9eb91..4165672 100644
>> --- a/drivers/gpio/gpio-lynxpoint.c
>> +++ b/drivers/gpio/gpio-lynxpoint.c
>> @@ -407,9 +407,33 @@ static int lp_gpio_runtime_resume(struct device *dev)
>>  	return 0;
>>  }
>>  
>> +static int lp_gpio_suspend(struct device *dev)
>> +{
>> +	return 0;
>> +}
> 
> If this function doesn't do anything why it needs to be defined here?
> 

I guess it doesn't, Added the suspend and resume functions as a pair, but only
resume turned out to do something,

I'll remove it.

-Mathias



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/