lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 19 Aug 2014 19:29:41 +0800
From:	Honggang Li <enjoymindful@...il.com>
To:	benjamin.romer@...sys.com, david.kershner@...sys.com,
	gregkh@...uxfoundation.org, erik.arfvidson@...sys.com,
	sparmaintainer@...sys.com
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Honggang Li <enjoymindful@...il.com>
Subject: [linux-next PATCH] print u64 with %llu

There are printk format issue and coding style issue for the lines
changed by this patch. This patch only fix the format issue. Please
take those coding style errors as false positives for this patch.

[real@...e linux-next]$ scripts/checkpatch.pl outgoing2/0001-staging-unisys-virthba-virthba.c-print-u64-with-llu.patch 
WARNING: line over 80 characters
#45: FILE: drivers/staging/unisys/virthba/virthba.c:520:
+    LOGINF("scsihost->max_channel=%u, max_id=%u, max_lun=%llu, cmd_per_lun=%u, max_sectors=%hu, sg_tablesize=%hu\n",

WARNING: line over 80 characters
#63: FILE: drivers/staging/unisys/virthba/virthba.c:1142:
+		LOGERR("SCSICMD ****FAILED scsicmd:0x%p op:0x%x <%d:%d:%d:%llu> 0x%x-0x%x-0x%x-0x%x-0x%x.\n",

WARNING: line over 80 characters
#72: FILE: drivers/staging/unisys/virthba/virthba.c:1151:
+			LOGERR("Throtling SCSICMD errors disk <%d:%d:%d:%llu>\n",

total: 0 errors, 3 warnings, 32 lines checked

outgoing2/0001-staging-unisys-virthba-virthba.c-print-u64-with-llu.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[real@...e linux-next]$ 

Honggang Li (1):
  staging: unisys/virthba/virthba.c print u64 with %llu

 drivers/staging/unisys/virthba/virthba.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ