linux-kernel - Re: [PATCH v6] input: drv260x: Add TI drv260x haptics driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140819192401.GA32080@core.coreip.homeip.net>
Date:	Tue, 19 Aug 2014 12:24:01 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dan Murphy <dmurphy@...com>
Cc:	mark.rutland@....com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v6] input: drv260x: Add TI drv260x haptics driver

Hi Dan,

On Fri, Aug 15, 2014 at 10:47:50AM -0500, Dan Murphy wrote:
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 2ff4425..99f6762 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -676,4 +676,13 @@ config INPUT_SOC_BUTTON_ARRAY
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called soc_button_array.
>  
> +config INPUT_DRV260X_HAPTICS
> +	tristate "TI DRV260X haptics support"
> +	depends on INPUT && I2C

This also needs "select REGMAP_I2C"

> +	help
> +	  Say Y to enable support for the TI DRV260X haptics driver.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called drv260x-haptics.
> +

[...]

> +#ifndef _LINUX_DRV260X_PDATA_H
> +#define _LINUX_DRV260X_PDATA_H
> +
> +struct drv260x_platform_data {
> +	int enable_gpio;

I do not see this used anywhere.

> +	u32 library_selection;
> +	u32 mode;
> +	u32 vib_rated_voltage;
> +	u32 vib_overdrive_voltage;
> +};
> +
> +#endif

I fixed up the above issues and did a few more formatting changes and applied
to my 'next' branch. Please take a peek and holler if you see something wrong.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/