linux-kernel - Re: [PATCH v6] input: drv260x: Add TI drv260x haptics driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49DEC525@DFLE09.ent.ti.com>
Date:	Tue, 19 Aug 2014 20:55:14 +0000
From:	"Murphy, Dan" <dmurphy@...com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	"mark.rutland@....com" <mark.rutland@....com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6] input: drv260x: Add TI drv260x haptics driver

Dmitry

On 08/19/2014 03:24 PM, Dmitry Torokhov wrote:
> On Tue, Aug 19, 2014 at 08:13:32PM +0000, Murphy, Dan wrote:
>> On 08/19/2014 03:07 PM, Dmitry Torokhov wrote:
>>> On Tue, Aug 19, 2014 at 07:35:06PM +0000, Murphy, Dan wrote:
>>>> Dmitry
>>>>

<snip>

>>> 	...
>>>
>>> That one I kept.
>>>
>>
>> Yes that is correct but the enable_gpio for non-dt enabled devices this enable_gpio
>> needs to come from the platform data structure.  Without the enable gpio in the platform data
>> structure there is no way for non-dt enabled devices to set the gpio value.
> 
> What else uses the platform data structure? You are accessing gpio by name, not
> by number, in the driver so I am not sure how non-dt case will use u32 defined
> in platform data.
> 
>>
>> The haptics instance just stores the gpio descriptor returned from this call.
> 
> Right.
> 
>>
>> The devm_gpiod looks at the platform data is CONFIG_OF is not set.
> 
> Umm, how? You do not pass it anywhere...

OK I drop my argument after drilling through gpio code.

Removal of this is OK.

Thanks

> 
> Thanks.
> 


-- 
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/