linux-kernel - Re: [PATCH] i2c: designware: deduce speed mode from device tree setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140820075222.GA1660@lahna.fi.intel.com>
Date:	Wed, 20 Aug 2014 10:52:22 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	atull@...nsource.altera.com
Cc:	wsa@...-dreams.de, baruch@...s.co.il, grant.likely@...aro.org,
	robh+dt@...nel.org, skuribay@...ox.com,
	Romain.Baeriswyl@...lis.com, rafael.j.wysocki@...el.com,
	alan@...ux.intel.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	delicious.quinoa@...il.com, dinguyen@...nsource.altera.com,
	yvanderv@...nsource.altera.com
Subject: Re: [PATCH] i2c: designware: deduce speed mode from device tree
 setting

On Tue, Aug 19, 2014 at 03:18:49PM -0500, atull@...nsource.altera.com wrote:
> From: Alan Tull <atull@...nsource.altera.com>
> 
> Use the documented, but unimplemented "clock-frequency"
> Device Tree setting as a guide on whether to set the speed
> mode bits in DW_IC_CON to standard or fast i2c mode.
> 
> Previously, the driver was hardwired to fast mode.  Default
> to fast mode if the "clock-frequency" property is not present
> for backwards compatiblity.
> 
> Signed-off-by: Alan Tull <atull@...nsource.altera.com>

I don't know much about the Device Tree bindings but the patch looks
good to me,

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/