linux-kernel - Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Aug 2014 12:36:11 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Andreas Färber <afaerber@...e.de>
CC:	Kukjin Kim <kgene.kim@...sung.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Mark Brown <broonie@...nel.org>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	Rahul Sharma <rahul.sharma@...sung.com>,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit
 and Pi boards

Hello Andreas,

On 08/20/2014 12:21 PM, Javier Martinez Canillas wrote:
> Hello Andreas,
> 
> Thanks a lot for your feedback.
> 
> On 08/19/2014 08:37 PM, Andreas Färber wrote:
>>>  &mmc_2 {
>>> +	vmmc-supply = <&tps65090_fet4>;
>>> +	vqmmc-supply = <&vqmmc_sdcard>;
>>>  	status = "okay";
>>>  	num-slots = <1>;
>>>  	supports-highspeed;
>> 
>> A convention that I picked up was to place overridden status property
>> first. Do your new properties really need to go before that?
>>
> 
> OF doesn't care about the order of the child nodes but I do agree that
> consistency is a good thing so I'll change that on v2.
> 

Actually I meant that I'll change this for a future re-post since I'm
completely dropping this patch from the series due Doug's explanation
about the CD line and VCCQ/VDD_IO being in the same power rail on Exynos5
SoCs.

Sorry for the noise...

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/