linux-kernel - Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201408201327.57376.arnd@arndb.de>
Date:	Wed, 20 Aug 2014 13:27:57 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Liviu Dudau <Liviu.Dudau@....com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Will Deacon <Will.Deacon@....com>,
	Jingoo Han <jg1.han@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Suravee Suthikulanit <suravee.suthikulpanit@....com>,
	"linux-pci" <linux-pci@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] drivers: pci: convert generic host controller to DT host bridge creation API

On Tuesday 12 August 2014, Liviu Dudau wrote:
> +       return of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops,
> +                                       gen_pci_setup, pci);

I had not noticed it earlier, but the setup callback is actually a feature
of the arm32 PCI code that I had hoped to avoid when moving to the
generic API. Can we do this as a more regular sequence of


	ret = of_create_pci_host_bridge(dev, 0, 0xff, &gen_pci_ops, pci);
	if (ret)
		return ret;

	ret = gen_pci_setup(pci);
	if (ret)
		pci_destroy_host_bridge(dev, pci);
	return ret;

?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/