linux-kernel - Re: [PATCH] i2c: designware: deduce speed mode from device tree setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140820123210.GA1373@katana>
Date:	Wed, 20 Aug 2014 07:32:11 -0500
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Romain Baeriswyl <Romain.Baeriswyl@...lis.com>
Cc:	Mark Rutland <mark.rutland@....com>, atull@...nsource.altera.com,
	baruch@...s.co.il,
	mika westerberg <mika.westerberg@...ux.intel.com>,
	grant likely <grant.likely@...aro.org>, robh+dt@...nel.org,
	skuribay@...ox.com, rafael j wysocki <rafael.j.wysocki@...el.com>,
	alan@...ux.intel.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	delicious quinoa <delicious.quinoa@...il.com>,
	dinguyen@...nsource.altera.com, yvanderv@...nsource.altera.com
Subject: Re: [PATCH] i2c: designware: deduce speed mode from device tree
 setting


> With the patch "i2c designware add support of I2C standard mode" I already proposed:
> - I2C standard mode is selected with 100kHz clock frequency.
> - I2C fast mode is selected with 400kHy clock frequency.
> - EINVAL error is returned if clock frequency is not 100000 and not 400000.

You forgot to send this patch to the i2c list. So, it didn't get into
patchwork which I rely on for tracking patches.

Please resend an updated version to the latest codebase. I like that it
has the EINVAL error checking.

> What about the other patch "i2c designware make SCL and SDA falling time configurable" ?

6468276b22069d4442aafcd8c59e5d8ccae23f5f upstream.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)