linux-kernel - Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark X1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140820031919.GB12639@saruman.home>
Date:	Tue, 19 Aug 2014 22:19:19 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Chen, Alvin" <alvin.chen@...el.com>
CC:	"balbi@...com" <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>
Subject: Re: [PATCH] USB: pch_udc: USB gadget device support for Intel Quark
 X1000

Hi,

On Wed, Aug 20, 2014 at 12:46:33AM +0000, Chen, Alvin wrote:
> 
> > Hi,
> > 
> > On Mon, Aug 04, 2014 at 10:22:54AM -0700, Chen, Alvin wrote:
> > > From: Bryan O'Donoghue <bryan.odonoghue@...el.com>
> > >
> > > This patch is to enable the USB gadget device for Intel Quark X1000
> > >
> > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...el.com>
> > > Signed-off-by: Bing Niu <bing.niu@...el.com>
> > > Signed-off-by: Alvin (Weike) Chen <alvin.chen@...el.com>
> > 
> > Can someone confirm to me this is not another incarnation of chipidea ?
> 
> No, this is not another incarnation of chipidea. And its cover letter is as following:
> 
> On Mon, Aug 04, 2014 at 11:00:07AM -0700, Chen, Alvin wrote:
> > From: "Alvin (Weike) Chen" <alvin.chen@...el.com>
> > 
> > Hi,
> > Intel Quark X1000 consists of one USB gadget device which can be PCI enumerated. 
> > pch_udc layer doesn't support it. Thus, we add support for Intel Quark 
> > X1000 USB gadget device as well.

hehe, right I *know* what the patch is doing. I can read the diff and
figure out that you're adding support for Quark to PCH UDC because
Quark's USB IP is the same, what I wasking was if that IP was actually
an instance of the chipidea UDC. After looking at the address space
definitions on both drivers, I see that it's not.

So tomorrow I'll look at this patch again.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)