lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Aug 2014 11:25:55 +0800 From: Hanjun Guo <hanjun.guo@...aro.org> To: Geoff Levand <geoff@...radead.org> CC: Catalin Marinas <catalin.marinas@....com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Mark Rutland <mark.rutland@....com>, linaro-acpi@...ts.linaro.org, Liviu Dudau <Liviu.Dudau@....com>, Lv Zheng <lv.zheng@...el.com>, Rob Herring <robh@...nel.org>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Robert Moore <robert.moore@...el.com>, linux-acpi@...r.kernel.org, Grant Likely <grant.likely@...aro.org>, Charles.Garcia-Tobin@....com, Robert Richter <rric@...nel.org>, Jason Cooper <jason@...edaemon.net>, Arnd Bergmann <arnd@...db.de>, Marc Zyngier <marc.zyngier@....com>, Will Deacon <will.deacon@....com>, Tomasz Nowicki <tomasz.nowicki@...aro.org>, Mark Brown <broonie@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, linux-arm-kernel@...ts.infradead.org, Graeme Gregory <graeme.gregory@...aro.org>, Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org, Sudeep Holla <Sudeep.Holla@....com>, Olof Johansson <olof@...om.net> Subject: Re: [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way On 2014-8-20 3:25, Geoff Levand wrote: > Hi Hanjun, > > On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote: >> On 2014-8-19 2:56, Geoff Levand wrote: > >>> message = acpi_disabled ? dn->full_name : ""; >>> >>> ... >>> >>> pr_warn("CPU %d: %s unsupported enable-method property: %s\n", >>> cpu, message, enable_method) >> >> In ACPI, there is no enable-method property, it is a term from, so I think the >> message printed can be separated. > > I think it better to have a single message that can cover all > than to have separate messages. Wouldn't the enable method be > "acpi-parking" or "acpi-psci"? Then something like this would > work: > > pr_warn("CPU %d: %s Unsupported enable method: %s\n", cpu, message, enable_method); Thanks for the suggestion, I will update it in next version. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists