linux-kernel - Re: [PATCH 2/2] fault-inject: add ratelimit option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppfvqlcu.fsf@openvz.org>
Date:	Wed, 20 Aug 2014 18:36:17 +0400
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] fault-inject: add ratelimit option

On Wed, 20 Aug 2014 23:20:18 +0900, Akinobu Mita <akinobu.mita@...il.com> wrote:
> This looks a bit redundant.  NULL pointer to "%pd" format produces
> "(null)" string, so this printk and if-else can be removed.
> 
> Also, this message line is a bit longer than usual kernel message.
> Should we put '\n' after "forcing a failure."?
> 
> This patch looks good to me.  Please feel free to add my ACK.
Ok. Here is updated version.

View attachment "0001-fault-inject-add-ratelimit-option-v2.patch" of type "text/x-patch" (3837 bytes)