linux-kernel - Re: [PATCH] staging: android: fix style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1408547047.23250.27.camel@joe-AO725>
Date:	Wed, 20 Aug 2014 08:04:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Purnendu Kapadia <pro8linux@...il.com>
Cc:	konkers@...roid.com, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: fix style issue

On Wed, 2014-08-20 at 15:13 +0100, Purnendu Kapadia wrote:
> checkpatch fix. add a line before the switch statement

Hello Purnendu.

This is a suboptimal patch description.

There is no generic style asking for a blank line
before a switch statement.

You are actually adding a blank line separating
declarations and code.

Specifying the change as a "checkpatch fix" is
also unnecessary.

A patch subject of

"[PATCH] staging: android: Add blank line after declaration"

with no patch description at all is probably good
enough.

> diff --git a/drivers/staging/android/sync.c b/drivers/staging/androchd/sync.c
[]
> @@ -705,6 +705,7 @@ static long sync_fence_ioctl(struct file *file, unsigned int cmd,
>  			     unsigned long arg)
>  {
>  	struct sync_fence *fence = file->private_data;
> +
>  	switch (cmd) {
>  	case SYNC_IOC_WAIT:
>  		return sync_fence_ioctl_wait(fence, arg);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/