[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140820155646.GN4266@lee--X1>
Date: Wed, 20 Aug 2014 16:56:46 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Peter Tyser <ptyser@...-inc.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH] mfd: lpc_ich: Add PCI ID for Intel Braswell
On Tue, 19 Aug 2014, Mika Westerberg wrote:
> From: Alan Cox <alan@...ux.intel.com>
>
> This is the same as used in Baytrail so add the new PCI ID to the driver's
> list of supported IDs.
>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> ---
> drivers/mfd/lpc_ich.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 7d8482ff5868..597f5f495d49 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -216,6 +216,7 @@ enum lpc_chipsets {
> LPC_BAYTRAIL, /* Bay Trail SoC */
> LPC_COLETO, /* Coleto Creek */
> LPC_WPT_LP, /* Wildcat Point-LP */
> + LPC_BRASWELL, /* Braswell SoC */
> };
>
> static struct lpc_ich_info lpc_chipset_info[] = {
> @@ -519,6 +520,10 @@ static struct lpc_ich_info lpc_chipset_info[] = {
> .name = "Wildcat Point_LP",
> .iTCO_version = 2,
> },
> + [LPC_BRASWELL] = {
> + .name = "Braswell SoC",
> + .iTCO_version = 3,
> + },
> };
>
> /*
> @@ -745,6 +750,7 @@ static const struct pci_device_id lpc_ich_ids[] = {
> { PCI_VDEVICE(INTEL, 0x9cc6), LPC_WPT_LP},
> { PCI_VDEVICE(INTEL, 0x9cc7), LPC_WPT_LP},
> { PCI_VDEVICE(INTEL, 0x9cc9), LPC_WPT_LP},
> + { PCI_VDEVICE(INTEL, 0x229C), LPC_BRASWELL},
Nit: All the other numbers are in lower case.
Please fix and re-send.
> { 0, }, /* End of list */
> };
> MODULE_DEVICE_TABLE(pci, lpc_ich_ids);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists