linux-kernel - Re: [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53F4C858.4040202@collabora.co.uk>
Date:	Wed, 20 Aug 2014 18:10:00 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: max77802: Remove unused fields from struct
 max77802_regulator_prv

Hello Axel,

On 08/20/2014 04:04 AM, Axel Lin wrote:
> Both num_regulators and *rdev[MAX77802_REG_MAX] are not used, remove them.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Right, these are not used indeed since are left overs from the previous
attempt to have a single driver for both max77686 and max77802 PMICs.
Sorry about that and thanks a lot for the patch.

>  
>  struct max77802_regulator_prv {
> -	int num_regulators;
> -	struct regulator_dev *rdev[MAX77802_REG_MAX];
>  	unsigned int opmode[MAX77802_REG_MAX];
>  };
>  
> 

I see that Mark already applied this but fwiw:

Acked-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/