linux-kernel - Re: [RFC] usb: gadget: serial: remove PREFIX macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F4CF2E.2070605@cogentembedded.com>
Date:	Wed, 20 Aug 2014 20:39:10 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	balbi@...com, Richard Leitner <richard.leitner@...data.com>
CC:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] usb: gadget: serial: remove PREFIX macro

Hello.

On 08/20/2014 07:54 PM, Felipe Balbi wrote:

>> Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with
>> the hardcoded ttyGS string.

>> This macro was mostly used in a few debug/warning messages and a lot of
>> hardcoded ttyGS existed beneath. It may have been used for renaming the
>> tty, but if done so most debug messages would have ignored this because
>> of the hardcoded strings.

>> Due to the fact the usage of this PREFIX instead of the hardcoded strings
>> in all debug calls would have resulted in a hard to read/grep code it
>> is removed completely.

>> Signed-off-by: Richard Leitner <richard.leitner@...data.com>

> patch looks fine, can you resend with RFC in the subject ?

    s/with/without/?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/