linux-kernel - Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tx57i1p1.fsf@rustcorp.com.au>
Date:	Thu, 21 Aug 2014 01:38:10 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jim Davis <jim.epost@...il.com>,
	Bertrand Jacquin <beber@...eeweb.net>
Cc:	linux-kbuild@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Willy Tarreau <w@....eu>
Subject: Re: [PATCH 1/3] modinst: wrap long lines in order to enhance cmd_modules_install

Jim Davis <jim.epost@...il.com> writes:
> On Tue, Aug 19, 2014 at 11:57 AM, Bertrand Jacquin <beber@...eeweb.net> wrote:
>> Note: shouldn't we use 'install -D $(2)/$@ $@' instead of mkdir
>> and cp ?
>
> Will an install with -D in that sense always be available?  That's not
> a flag in the original (BSD) program, and I did find one SPARC system
> -- admittedly an ancient one -- where the install program had a -D
> option but it did something else.  install isn't listed as a required
> program in Documentation/Changes, for that matter.

Yes, we don't count on install.  And ISTR that install -D would try to
change perms on directories in the path, which can fail if you don't own
them and aren't root...

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/