linux-kernel - Re: [PATCH] nfs: use canonical path in nfs_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1408576235.2618.47.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 20 Aug 2014 16:10:35 -0700
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Xiong Zhou <xzhou@...hat.com>
Cc:	trond.myklebust@...marydata.com, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: use canonical path in nfs_show_devname

On Tue, 2014-08-19 at 23:06 -0400, Xiong Zhou wrote:
> When export root dir(/) via nfs, and mount a particular dir under root, eg
> /nfsexport, there will be defect double slash output in /proc/mounts, like
> localhost://nfsexport.
> 
> Signed-off-by: Xiong Zhou <xzhou@...hat.com>
> ---
>  fs/nfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index e4499d5..62b1cab 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -780,7 +780,7 @@ int nfs_show_devname(struct seq_file *m, struct dentry *root)
>  	int err = 0;
>  	if (!page)
>  		return -ENOMEM;
> -	devname = nfs_path(&dummy, root, page, PAGE_SIZE, 0);
> +	devname = nfs_path(&dummy, root, page, PAGE_SIZE, 1);
>  	if (IS_ERR(devname))
>  		err = PTR_ERR(devname);
>  	else

This will reintroduce the problem reported in
<https://bugs.debian.org/669314>.

Ben.

-- 
Ben Hutchings
If at first you don't succeed, you're doing about average.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)