| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <53F5878D.3030700@samsung.com> Date: Thu, 21 Aug 2014 14:45:49 +0900 From: Chanwoo Choi <cw00.choi@...sung.com> To: myungjoo.ham@...sung.com Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, Mark Brown <broonie@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>, "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org> Subject: Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C Dear Myungjoo, On 08/21/2014 02:27 PM, MyungJoo Ham wrote: >> Hi Geert >> >> Thanks for your report. I already sent a patch[1] to fix this build break >> and I'll send pull request to includec this patch in 3.17-rc2. >> >> [1] https://lkml.org/lkml/2014/8/13/761 >> >> Best Regards, >> Chanwoo Choi > > I do not object to this patch or your patch[1]. > > However, wouldn't it be better to add depends on I2C at REGMAP_I2C? > When you use REGMAP_I2C, you assume that I2C is already there, don't you? The previous REGMAP_I2C has not the dependency on I2C. So, Greert posted following patch[1] to fix it. [1] https://lkml.org/lkml/2014/8/17/27 Also, if I2C is 'm' (module) and some driver has not dependency on I2C, build break happen. Thanks Chanwoo Choi, > > > Cheers, > MyungJoo > >> >> >> On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote: >>> EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n: >>> >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_byte_reg_read¡¯: >>> drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ¡®i2c_smbus_read_byte_data¡¯ >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_byte_reg_write¡¯: >>> drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ¡®i2c_smbus_write_byte_data¡¯ >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_word_reg_read¡¯: >>> drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ¡®i2c_smbus_read_word_data¡¯ >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_smbus_word_reg_write¡¯: >>> drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ¡®i2c_smbus_write_word_data¡¯ >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_i2c_write¡¯: >>> drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ¡®i2c_master_send¡¯ >>> drivers/base/regmap/regmap-i2c.c: In function ¡®regmap_i2c_gather_write¡¯: >>> drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ¡®i2c_check_functionality¡¯ >>> drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ¡®i2c_transfer¡¯ >>> >>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> >>> --- >>> drivers/extcon/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig >>> index 6f2f4727de2c..764f3a113e0a 100644 >>> --- a/drivers/extcon/Kconfig >>> +++ b/drivers/extcon/Kconfig >>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS >>> >>> config EXTCON_SM5502 >>> tristate "SM5502 EXTCON support" >>> + depends on I2C >>> select IRQ_DOMAIN >>> select REGMAP_I2C >>> select REGMAP_IRQ >>> >> >> >> >> >> >> >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists