linux-kernel - Re: [PATCH] kbuild: Make scripts executable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F5BCC8.4060000@suse.cz>
Date:	Thu, 21 Aug 2014 11:32:56 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Masahiro Yamada <yamada.m@...panasonic.com>
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: Make scripts executable

On 2014-08-21 05:25, Masahiro Yamada wrote:
> Hi Michal,
> 
> 
> On Wed, 20 Aug 2014 16:10:48 +0200
> Michal Marek <mmarek@...e.cz> wrote:
> 
>> The Makefiles call the respective interpreter explicitly, but this makes
>> it easier to use the scripts manually.
>>
>> Signed-off-by: Michal Marek <mmarek@...e.cz>
> 
> 
> I am not sure at all, but
> it seems scripts/checkpatch.pl has a rule
> to ban execute permissions.

I didn't know about this, but the intent of the rule seems to be to
avoid *.c files with execute permissions.


> # Check for incorrect file permissions
>                 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
>                         my $permhere = $here . "FILE: $realfile\n";
>                         if ($realfile !~ m@...ipts/@ &&
>                             $realfile !~ /\.(py|pl|awk|sh)$/) {

Here it explicitly skips files below scripts/ and files with known
script suffixes.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/