linux-kernel - Re: [PATCHv3] thermal: exynos: Add support for TRIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F5CACF.4050600@suse.de>
Date:	Thu, 21 Aug 2014 12:32:47 +0200
From:	Andreas Färber <afaerber@...e.de>
To:	Chanwoo Choi <cw00.choi@...sung.com>,
	"edubezval@...il.com" <edubezval@...il.com>
CC:	Zhang Rui <rui.zhang@...el.com>,
	"Valentin, Eduardo" <eduardo.valentin@...com>,
	Amit Kachhap <amit.daniel@...sung.com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>, l.majewski@...sung.com,
	naveen krishna <ch.naveen@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv3] thermal: exynos: Add support for TRIM_RELOAD feature
 at Exynos3250

Hello,

Am 21.08.2014 03:38, schrieb Chanwoo Choi:
> On 08/20/2014 10:38 PM, edubezval@...il.com wrote:
>> On Tue, Aug 19, 2014 at 7:52 PM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
>>> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
>>> index aa8e0de..8cd609c 100644
>>> --- a/drivers/thermal/samsung/exynos_tmu_data.c
>>> +++ b/drivers/thermal/samsung/exynos_tmu_data.c
>>> @@ -95,6 +95,8 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = {
>>>         .triminfo_data = EXYNOS_TMU_REG_TRIMINFO,
>>>         .triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT,
>>>         .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
>>> +       .triminfo_ctrl[0] = EXYNOS_TMU_TRIMINFO_CON1,
>>> +       .triminfo_ctrl[1] = EXYNOS_TMU_TRIMINFO_CON2,
>>>         .tmu_ctrl = EXYNOS_TMU_REG_CONTROL,
>>>         .test_mux_addr_shift = EXYNOS4412_MUX_ADDR_SHIFT,
>>>         .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT,
>>> @@ -160,8 +162,11 @@ static const struct exynos_tmu_registers exynos3250_tmu_registers = {
>>>                 .temp_level = 95, \
>>>         }, \
>>>         .freq_tab_count = 2, \
>>> +       .triminfo_reload[0] = 0x1, \
>>> +       .triminfo_reload[1] = 0x11, \
>>
>> What does 0x1 mean? How about 0x11?
> 
> The bit of 'RELOAD' field in TRIMINFO_CONTROL register is [0].
> and The bit of 'AC Time' field in TRIMINFO_CONTROL register is [5:4].
> 
> 0x1 means that set RELOAD field.
> 0x11 means that set RELOAD field and ACTIME field.

Might be a good idea to use #defines for 0x1 and 0x10 then?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/