linux-kernel - Re: [PATCH] toshiba_acpi.c - fix busted keyboard backlight logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 14:10:34 +0300 (EEST)
From:	Ari Sundholm <asundhol@...hut.fi>
To:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
cc:	Matthew Garrett <matthew.garrett@...ula.com>,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] toshiba_acpi.c - fix busted keyboard backlight logic


On Wed, 20 Aug 2014, Valdis Kletnieks wrote:

> Both the original and the first attempted patch managed to get the logic wrong.
> So we fix it so we only continue if sscanf returns exactly one value, and it
> has to be either 1 or 2.  Apparently, programmers are getting out and hacking
> code without remembering de Morgan's Laws...
> 
> Patch is against the file that results from Ari's revert of the previous
> patch.
> 
> Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@...edu>
> 
> --
> --- drivers/platform/x86/toshiba_acpi.c.orig	2014-08-20 14:45:52.159898938 -0400
> +++ drivers/platform/x86/toshiba_acpi.c	2014-08-20 14:47:55.102444985 -0400
> @@ -1258,7 +1258,7 @@ static ssize_t toshiba_kbd_bl_mode_store
>  	int mode = -1;
>  	int time = -1;
>  
> -	if (sscanf(buf, "%i", &mode) != 1 && (mode != 2 || mode != 1))
> +	if (sscanf(buf, "%i", &mode) != 1 || !(mode == 2 || mode == 1))
>  		return -EINVAL;
>  
>  	/* Set the Keyboard Backlight Mode where:

Looks good to me.

It seems Matthew already reverted the bad commit in mainline commit 
8039aabb6c9f802bca04cc77ca210060a5b53916, but didn't fix the original 
logic yet.

Matthew, could you apply Valdis' patch so this gets fixed once and for 
all?

Best regards,
Ari Sundholm
asundhol@...hut.fi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/