linux-kernel - Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 14:28:29 +0300
From:	Diana Craciun <diana.craciun@...escale.com>
To:	Jingchang Lu <jingchang.lu@...escale.com>
CC:	<mturquette@...aro.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE
 support

I think you should cc also linuxppc-dev as it touches common code.

On 08/04/2014 12:45 PM, Jingchang Lu wrote:
> Signed-off-by: Jingchang Lu <jingchang.lu@...escale.com>
> ---
>   drivers/clk/Kconfig           | 7 ++++---
>   drivers/clk/clk-ppc-corenet.c | 5 +++++
>   2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index cfd3af7..8784704 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -82,11 +82,12 @@ config COMMON_CLK_AXI_CLKGEN
>   	  FPGAs. It is commonly used in Analog Devices' reference designs.
>   
>   config CLK_PPC_CORENET
> -	bool "Clock driver for PowerPC corenet platforms"
> -	depends on PPC_E500MC && OF
> +	bool "Clock driver for PowerPC corenet and compatible ARM-based platforms"
> +	depends on (PPC_E500MC || ARM) && OF
>   	---help---
>   	  This adds the clock driver support for Freescale PowerPC corenet
> -	  platforms using common clock framework.
> +	  platforms and compatible Freescale ARM based platforms using common
> +	  clock framework.
>   
>   config COMMON_CLK_XGENE
>   	bool "Clock driver for APM XGene SoC"
> diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c

Can't this file be renamed in order to reflect that is common between 
PPC and ARM? It is strange to be named ppc_xxx and to be used by ARM kernel.

> index 8e58edf..7692cac 100644
> --- a/drivers/clk/clk-ppc-corenet.c
> +++ b/drivers/clk/clk-ppc-corenet.c
> @@ -305,3 +305,8 @@ static int __init ppc_corenet_clk_init(void)
>   	return platform_driver_register(&ppc_corenet_clk_driver);
>   }
>   subsys_initcall(ppc_corenet_clk_init);
> +
> +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", core_pll_init);
> +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", core_mux_init);
> +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", core_mux_init);

Diana

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/