linux-kernel - Re: [PATCH v9 4/9] arm: ks8695: Migrate debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53F5DBFD.2020502@uclinux.org>
Date:	Thu, 21 Aug 2014 21:46:05 +1000
From:	Greg Ungerer <gerg@...inux.org>
To:	Daniel Thompson <daniel.thompson@...aro.org>,
	Russell King <linux@....linux.org.uk>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	spear-devel@...t.st.com, Arnd Bergmann <arnd@...db.de>,
	Paul Bolle <pebolle@...cali.nl>, patches@...aro.org,
	linaro-kernel@...ts.linaro.org,
	Arnd Bergmann <arnd.bergmann@...aro.org>
Subject: Re: [PATCH v9 4/9] arm: ks8695: Migrate debug_ll macros to shared
 directory

Hi Daniel,

On 20/08/14 01:16, Daniel Thompson wrote:
> As part of the migration a couple of uart definitions have been copied
> from of the platform specific header files.
>
> Note that, in order to keep oldconfig working nicely we must defer the
> removal of arch/arm/mach-ks8695/include/mach/debug-macro.S until
> DEBUG_LL_UART_NONE has been removed.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Greg Ungerer <gerg@...inux.org>
> Cc: Arnd Bergmann <arnd.bergmann@...aro.org>
> ---
>   arch/arm/Kconfig.debug                                         |  8 ++++++++
>   .../include/mach/debug-macro.S => include/debug/ks8695.S}      | 10 +++++++---
>   2 files changed, 15 insertions(+), 3 deletions(-)
>   rename arch/arm/{mach-ks8695/include/mach/debug-macro.S => include/debug/ks8695.S} (80%)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 9c46729..97c3058 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -348,6 +348,13 @@ choice
>   		  Say Y here if you want the debug print routines to direct
>   		  their output to UART1 serial port on KEYSTONE2 devices.
>   
> +	config DEBUG_KS8695_UART
> +		bool "KS8695 Debug UART"
> +		depends on ARCH_KS8695
> +		help
> +		  Say Y here if you want kernel low-level debugging support
> +		  on KS8695.
> +
>   	config DEBUG_MMP_UART2
>   		bool "Kernel low-level debugging message via MMP UART2"
>   		depends on ARCH_MMP
> @@ -1017,6 +1024,7 @@ config DEBUG_LL_INCLUDE
>   				 DEBUG_IMX6Q_UART || \
>   				 DEBUG_IMX6SL_UART || \
>   				 DEBUG_IMX6SX_UART
> +	default "debug/ks8695.S" if DEBUG_KS8695_UART
>   	default "debug/msm.S" if DEBUG_MSM_UART || DEBUG_QCOM_UARTDM
>   	default "debug/omap2plus.S" if DEBUG_OMAP2PLUS_UART
>   	default "debug/s3c24xx.S" if DEBUG_S3C24XX_UART
> diff --git a/arch/arm/mach-ks8695/include/mach/debug-macro.S b/arch/arm/include/debug/ks8695.S
> similarity index 80%
> rename from arch/arm/mach-ks8695/include/mach/debug-macro.S
> rename to arch/arm/include/debug/ks8695.S
> index a79e489..961da1f 100644
> --- a/arch/arm/mach-ks8695/include/mach/debug-macro.S
> +++ b/arch/arm/include/debug/ks8695.S
> @@ -1,5 +1,5 @@
>   /*
> - * arch/arm/mach-ks8695/include/mach/debug-macro.S
> + * arch/arm/include/debug/ks8695.S
>    *
>    * Copyright (C) 2006 Ben Dooks <ben@...tec.co.uk>
>    * Copyright (C) 2006 Simtec Electronics
> @@ -11,8 +11,12 @@
>    * published by the Free Software Foundation.
>    */
>   
> -#include <mach/hardware.h>
> -#include <mach/regs-uart.h>
> +#define KS8695_UART_PA	0x03ffe000
> +#define KS8695_UART_VA	0xf00fe000
> +#define KS8695_URTH	(0x04)
> +#define KS8695_URLS	(0x14)
> +#define URLS_URTE	(1 << 6)
> +#define URLS_URTHRE	(1 << 5)

Whats the thinking behind moving these definitions here?
Is there a plan to move/change regs-uart.h?

Regards
Greg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/