linux-kernel - Re: [PATCH] irqchip: renesas-intc-irqpin: Add suspend-to-RAM wake up support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140821124550.GX12769@titan.lakedaemon.net>
Date:	Thu, 21 Aug 2014 08:45:50 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Geert Uytterhoeven <geert+renesas@...der.be>
Cc:	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: renesas-intc-irqpin: Add suspend-to-RAM wake
 up support

Geert,

On Wed, Aug 20, 2014 at 04:49:32PM +0200, Geert Uytterhoeven wrote:
> Set the ->irq_enable() and ->irq_disable() methods to NULL to enable
> lazy disable of interrupts, and set IRQCHIP_MASK_ON_SUSPEND to tell the
> core that only IRQs marked as wake-ups need to stay enabled during
> suspend-to-RAM.
> 
> This makes wake-up by gpio-keys from suspend-to-RAM work on
> r8a7740/Armadillo.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Not tested on sh73a0/kzm9g, r8a7778/bock-w, r8a7779/marzen
> 
> Similar changes for gpio-rcar and renesas-irqc went in before, but
> split in two parts:
>   - commit 272012d0f748de2e ("irqchip: renesas-irqc: Use lazy disable")
>   - commit 6a7e3b3007b5396a ("irqchip: renesas-irqc: Enable mask on suspend")
>   - commit fba968a1e6b84be0 ("gpio: rcar: Use lazy disable")
>   - commit 403961120667bed7 ("gpio: rcar: Enable mask on suspend")
> 
> However, I believe it doesn't make much sense to split this:
>   - Enabling lazy disable on its own introduces a regression, as it
>     causes the system to wake-up on IRQs not marked as wake-ups,
>   - Adding IRQCHIP_MASK_ON_SUSPEND on its own doesn't have any impact.
> ---
>  drivers/irqchip/irq-renesas-intc-irqpin.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied to irqchip/core

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/