linux-kernel - Re: [PATCH] mfd: da9052-i2c: Remove duplicate test for I2C_FUNC_SMBUS_BYTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140821153936.GP4266@lee--X1>
Date:	Thu, 21 Aug 2014 16:39:36 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	David Dajun Chen <dchen@...semi.com>,
	Support Opensource <support.opensource@...semi.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: da9052-i2c: Remove duplicate test for
 I2C_FUNC_SMBUS_BYTE_DATA functionality

On Fri, 15 Aug 2014, Axel Lin wrote:

> Since commit b42261078a91 ("regmap: i2c: fallback to SMBus if the adapter
> does not support standard I2C"), regmap-i2c will check the
> I2C_FUNC_SMBUS_[BYTE|WORD]_DATA functionality based on the regmap_config
> setting if the adapter does not support standard I2C.
> 
> So remove the I2C_FUNC_SMBUS_BYTE_DATA functionality check in the driver code.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/da9052-i2c.c | 7 -------
>  1 file changed, 7 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 6da8ec8..ec39287 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -140,13 +140,6 @@ static int da9052_i2c_probe(struct i2c_client *client,
>  	if (!da9052)
>  		return -ENOMEM;
>  
> -	if (!i2c_check_functionality(client->adapter,
> -				     I2C_FUNC_SMBUS_BYTE_DATA)) {
> -		dev_info(&client->dev, "Error in %s:i2c_check_functionality\n",
> -			 __func__);
> -		return  -ENODEV;
> -	}
> -
>  	da9052->dev = &client->dev;
>  	da9052->chip_irq = client->irq;
>  	da9052->fix_io = da9052_i2c_fix;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/