lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Aug 2014 17:32:00 +0000 From: "Murphy, Dan" <dmurphy@...com> To: "Menon, Nishanth" <nm@...com>, Dmitry Torokhov <dtor@...l.ru>, "Dmitry Torokhov" <dmitry.torokhov@...il.com> CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton On 08/21/2014 12:19 PM, Menon, Nishanth wrote: > On 08/21/2014 11:59 AM, Murphy, Dan wrote: > [...] > Ooops.. missed answering one addition statement: > >>> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val); >> >> Probably should check the return to make sure the value exists and that is is >> within an expected range. > It is an optional parameter and may not exist in dt. when it does > exist, the logic tries to do a best match (this is the for loop in the > logic just below). > The issue is val might be returned as a negative which will then proceed to set the config->long_press_time_val to the lowest time value which then overrides your initial setting of config->long_press_time_val = ARRAY_SIZE(lpk_times) - 1; Dan -- ------------------ Dan Murphy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists