linux-kernel - Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master receive mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2014 22:04:31 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Addy Ke <addy.ke@...k-chips.com>, wsa@...-dreams.de,
	max.schwarz@...ine.de, heiko@...ech.de, olof@...om.net,
	dianders@...omium.org
CC:	huangtao@...k-chips.com, hl@...k-chips.com, yzq@...k-chips.com,
	zyw@...k-chips.com, linux-kernel@...r.kernel.org,
	kever.yang@...k-chips.com, linux-rockchip@...ts.infradead.org,
	xjq@...k-chips.com, linux-i2c@...r.kernel.org,
	caesar.wang@...k-chips.com, cf@...k-chips.com, hj@...k-chips.com,
	zhengsq@...k-chips.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] i2c: rk3x: fix bug that cause transfer fails in master
 receive mode

Hello.

On 08/21/2014 09:50 PM, Addy Ke wrote:

> In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data
> in one transaction, so the size of data to be write/read to/from
> TXDATAx/RXDATAx must be less than or equal 32 bytes at a time.

> Test on pinky board, elan receive 158 bytes data.

> Signed-off-by: Addy Ke <addy.ke@...k-chips.com>
> ---
>   drivers/i2c/busses/i2c-rk3x.c | 3 +++
>   1 file changed, 3 insertions(+)

> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index 69e1185..dc0aa64 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -323,6 +323,9 @@ static void rk3x_i2c_handle_read(struct rk3x_i2c *i2c, unsigned int ipd)
>   	/* ack interrupt */
>   	i2c_writel(i2c, REG_INT_MBRF, REG_IPD);
>
> +	/* Can only handle a maximum of 32 bytes at a time */
> +	len = (len > 32) ? 32 : len;

    Why not min(len, 32)? Or even:

	if (len > 32)
		len = 32;

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/