linux-kernel - Re: [PATCH 1/1] net:fec: buffer descriptor member variable order in IMX6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHrpEqTtsLk3x3ocHSXh3C1ysvqq+RSg-sD0YZ5O8iuZfMYvEg@mail.gmail.com>
Date:	Thu, 21 Aug 2014 14:30:12 -0500
From:	Zhi Li <lznuaa@...il.com>
To:	Zhu Yanjun <zyjzyj2000@...il.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Zhu Yanjun <Yanjun.Zhu@...driver.com>,
	Frank Li <Frank.Li@...escale.com>
Subject: Re: [PATCH 1/1] net:fec: buffer descriptor member variable order in IMX6

On Thu, Aug 21, 2014 at 4:21 AM, Zhu Yanjun <zyjzyj2000@...il.com> wrote:
> From Reference Manual, freescale IMX6 is little endian mode. Therefore
> the first structure field is length, the second is status.
>
> CC: David Miller <davem@...emloft.net>
> CC: Frank Li <Frank.Li@...escale.com>
> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@...driver.com>
> ---
>  drivers/net/ethernet/freescale/fec.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/ethernet/freescale/fec.h
> index 671d080..96a5f8a 100644
> --- a/drivers/net/ethernet/freescale/fec.h
> +++ b/drivers/net/ethernet/freescale/fec.h
> @@ -147,7 +147,8 @@
>  /*
>   *     Define the buffer descriptor structure.
>   */
> -#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28)
> +#if defined(CONFIG_ARCH_MXC) || defined(CONFIG_SOC_IMX28) || \
> +                       defined(CONFIG_ARCH_MX6)

CONFIG_ARCH_MXC already included CONFIG_ARCH_MX6
ARCH_MXC included whole MX serial, MX35, MX5x, MX6x.

IMX28 is special, coming from sigmatel chip.

So it is not necessary to add ARCH_MX6


Best regards
Frank Li

>  struct bufdesc {
>         unsigned short cbd_datlen;      /* Data length */
>         unsigned short cbd_sc;  /* Control and status info */
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/