linux-kernel - Re: [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201408210533.00196.arnd@arndb.de>
Date:	Thu, 21 Aug 2014 05:32:59 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Gaël PORTAY <gael.portay@...il.com>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, Nicolas Ferre <nicolas.ferre@...el.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@...osoft.com>
Subject: Re: [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe

On Wednesday 20 August 2014, Gaël PORTAY wrote:
> +static void tc_shutdown (struct platform_device *pdev)
> +{
> +       int i;
> +       struct atmel_tc *tc = platform_get_drvdata(pdev);
> +
> +       for (i = 0; i < 3; i++)
> +               __raw_writel(0xff, tc->regs + ATMEL_TC_REG(i, IDR));
> +}

In general, __raw_readl/__raw_writel are not meant to be called by device drivers.

Just use readl/writel by default, or readl_relaxed/writel_relaxed if the code is
performance critical and you are sure it is safe to use them.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/