lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 21 Aug 2014 09:59:47 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Kiran Padwal <kiran.padwal@...rtplayin.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	spear-devel <spear-devel@...t.st.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: spear: Make of_device_id array const

On Wed, Aug 20, 2014 at 7:56 PM, Kiran Padwal
<kiran.padwal@...rtplayin.com> wrote:
> Make of_device_id array const, because all OF functions handle it as const.
>
> Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> ---
>  drivers/pinctrl/spear/pinctrl-spear1310.c |    2 +-
>  drivers/pinctrl/spear/pinctrl-spear1340.c |    2 +-
>  drivers/pinctrl/spear/pinctrl-spear300.c  |    2 +-
>  drivers/pinctrl/spear/pinctrl-spear310.c  |    2 +-
>  drivers/pinctrl/spear/pinctrl-spear320.c  |    2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-spear1310.c b/drivers/pinctrl/spear/pinctrl-spear1310.c
> index 1a8bbfe..6d57d43 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear1310.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear1310.c
> @@ -2692,7 +2692,7 @@ static struct spear_pinctrl_machdata spear1310_machdata = {
>         .modes_supported = false,
>  };
>
> -static struct of_device_id spear1310_pinctrl_of_match[] = {
> +static const struct of_device_id spear1310_pinctrl_of_match[] = {
>         {
>                 .compatible = "st,spear1310-pinmux",
>         },
> diff --git a/drivers/pinctrl/spear/pinctrl-spear1340.c b/drivers/pinctrl/spear/pinctrl-spear1340.c
> index 873966e..d243e43 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear1340.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear1340.c
> @@ -2008,7 +2008,7 @@ static struct spear_pinctrl_machdata spear1340_machdata = {
>         .modes_supported = false,
>  };
>
> -static struct of_device_id spear1340_pinctrl_of_match[] = {
> +static const struct of_device_id spear1340_pinctrl_of_match[] = {
>         {
>                 .compatible = "st,spear1340-pinmux",
>         },
> diff --git a/drivers/pinctrl/spear/pinctrl-spear300.c b/drivers/pinctrl/spear/pinctrl-spear300.c
> index 4777c0d..9db83e9 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear300.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear300.c
> @@ -646,7 +646,7 @@ static struct spear_function *spear300_functions[] = {
>         &gpio1_function,
>  };
>
> -static struct of_device_id spear300_pinctrl_of_match[] = {
> +static const struct of_device_id spear300_pinctrl_of_match[] = {
>         {
>                 .compatible = "st,spear300-pinmux",
>         },
> diff --git a/drivers/pinctrl/spear/pinctrl-spear310.c b/drivers/pinctrl/spear/pinctrl-spear310.c
> index ed1d360..db775a4 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear310.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear310.c
> @@ -371,7 +371,7 @@ static struct spear_function *spear310_functions[] = {
>         &tdm_function,
>  };
>
> -static struct of_device_id spear310_pinctrl_of_match[] = {
> +static const struct of_device_id spear310_pinctrl_of_match[] = {
>         {
>                 .compatible = "st,spear310-pinmux",
>         },
> diff --git a/drivers/pinctrl/spear/pinctrl-spear320.c b/drivers/pinctrl/spear/pinctrl-spear320.c
> index b8e290a..80fbd68 100644
> --- a/drivers/pinctrl/spear/pinctrl-spear320.c
> +++ b/drivers/pinctrl/spear/pinctrl-spear320.c
> @@ -3410,7 +3410,7 @@ static struct spear_function *spear320_functions[] = {
>         &i2c2_function,
>  };
>
> -static struct of_device_id spear320_pinctrl_of_match[] = {
> +static const struct of_device_id spear320_pinctrl_of_match[] = {
>         {
>                 .compatible = "st,spear320-pinmux",
>         },

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists