linux-kernel - Re: [PATCH v4 1/2] watchdog: Add Cadence WDT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 13:24:54 +0530
From:	Harini Katakam <harinikatakamlinux@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"wim@...ana.be" <wim@...ana.be>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>,
	"michals@...inx.com" <michals@...inx.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	svemula@...inx.com, anirudh@...inx.com
Subject: Re: [PATCH v4 1/2] watchdog: Add Cadence WDT driver

Hi Guenter,

On Fri, Aug 22, 2014 at 1:03 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> On Thu, Aug 21, 2014 at 11:57:22AM -0700, Guenter Roeck wrote:
>> On Thu, Jul 31, 2014 at 12:10:54PM +0530, Harini Katakam wrote:
>> > Add Cadence WDT driver. This is used by Xilinx Zynq.
>> >
>> > Signed-off-by: Harini Katakam <harinik@...inx.com>
>>
>> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>
> Hah, that was too fast. The driver causes build errors for a number or
> architectures, including x86_64.
>
> drivers/watchdog/cadence_wdt.c: In function 'cdns_wdt_writereg':
> drivers/watchdog/cadence_wdt.c:93:2: error: implicit declaration of function
> 'writel_relaxed' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/watchdog/cadence_wdt.o] Error 1
> make[1]: *** [drivers/watchdog] Error 2
>
> Please make sure that the driver is only configurable for architectures
> supporting writel_relaxed.

There were a couple of patches earlier to add relaxed helpers for all
architectures - I guess they are not applied yet.
I'll resend series adding dependency on ARM.

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/