linux-kernel - RE: [PATCH v7] ARM: dts: Prepare node labels for exynos5250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <080101cfbdf6$c8fd1f30$5af75d90$@samsung.com>
Date:	Fri, 22 Aug 2014 19:49:44 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Andreas Färber' <afaerber@...e.de>,
	linux-samsung-soc@...r.kernel.org
Cc:	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	'Vincent Palatin' <vpalatin@...omium.org>,
	'Doug Anderson' <dianders@...omium.org>,
	'Javier Martinez Canillas' <javier.martinez@...labora.co.uk>,
	'Tomasz Figa' <t.figa@...sung.com>,
	'Ben Dooks' <ben-linux@...ff.org>,
	'Rob Herring' <robh+dt@...nel.org>,
	'Pawel Moll' <pawel.moll@....com>,
	'Mark Rutland' <mark.rutland@....com>,
	'Ian Campbell' <ijc+devicetree@...lion.org.uk>,
	'Kumar Gala' <galak@...eaurora.org>,
	'Russell King' <linux@....linux.org.uk>,
	'open list' <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7] ARM: dts: Prepare node labels for exynos5250

Andreas Färber wrote:
> 
> Allows them to be extended by reference.
> 
> Reviewed-by: Doug Anderson <dianders@...omium.org>
> Signed-off-by: Andreas Färber <afaerber@...e.de>
> ---
>  v6 -> v7:
>  * Dropped uart* labels (Tomasz Figa)
> 
>  v6: Split off from Snow/SMDK cleanups (Doug Anderson)
> 
>  arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 492e1eff37bd..42eafd19cfb2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -218,7 +218,7 @@
>  		clock-names = "fimg2d";
>  	};
> 
> -	codec@...00000 {
> +	mfc: codec@...00000 {
>  		compatible = "samsung,mfc-v6";
>  		reg = <0x11000000 0x10000>;
>  		interrupts = <0 96 0>;
> @@ -227,7 +227,7 @@
>  		clock-names = "mfc";
>  	};
> 
> -	rtc@...E0000 {
> +	rtc: rtc@...E0000 {
>  		clocks = <&clock CLK_RTC>;
>  		clock-names = "rtc";
>  		status = "disabled";
> @@ -261,7 +261,7 @@
>  		clock-names = "uart", "clk_uart_baud0";
>  	};
> 
> -	sata@...F0000 {
> +	sata: sata@...F0000 {
>  		compatible = "snps,dwc-ahci";
>  		samsung,sata-freq = <66>;
>  		reg = <0x122F0000 0x1ff>;
> @@ -573,7 +573,7 @@
>  		#phy-cells = <1>;
>  	};
> 
> -	usb@...10000 {
> +	ehci: usb@...10000 {

I'm not sure which one is recommended between above and "ehci: ehci@...10000 {"

>  		compatible = "samsung,exynos4210-ehci";
>  		reg = <0x12110000 0x100>;
>  		interrupts = <0 71 0>;
> @@ -588,7 +588,7 @@
>  		};
>  	};
> 
> -	usb@...20000 {
> +	ohci: usb@...20000 {

Same as above...

>  		compatible = "samsung,exynos4210-ohci";
>  		reg = <0x12120000 0x100>;
>  		interrupts = <0 71 0>;
> @@ -725,7 +725,7 @@
>  		clock-names = "gscl";
>  	};
> 
> -	hdmi {
> +	hdmi: hdmi {

Should be

+	hdmi: hdmi@...30000 { ?

>  		compatible = "samsung,exynos4212-hdmi";
>  		reg = <0x14530000 0x70000>;
>  		interrupts = <0 95 0>;
> @@ -751,14 +751,14 @@
>  		#phy-cells = <0>;
>  	};
> 
> -	dp-controller@...B0000 {
> +	dp: dp-controller@...B0000 {
>  		clocks = <&clock CLK_DP>;
>  		clock-names = "dp";
>  		phys = <&dp_phy>;
>  		phy-names = "dp";
>  	};
> 
> -	fimd@...00000 {
> +	fimd: fimd@...00000 {
>  		clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
>  		clock-names = "sclk_fimd", "fimd";
>  	};
> --
> 2.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/