| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Aug 2014 15:05:17 +0200
From: Jiri Olsa <jolsa@...nel.org>
To: linux-kernel@...r.kernel.org
Cc: Jiri Olsa <jolsa@...nel.org>, Andi Kleen <andi@...stfloor.org>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
David Ahern <dsahern@...il.com>,
Frederic Weisbecker <fweisbec@...il.com>,
Ingo Molnar <mingo@...nel.org>,
"Jen-Cheng(Tommy) Huang" <tommy24@...ech.edu>,
Namhyung Kim <namhyung@...nel.org>,
Paul Mackerras <paulus@...ba.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Stephane Eranian <eranian@...gle.com>
Subject: [PATCH 4/5] perf tools: Add hash of periods for struct perf_sample_id
With PERF_FORMAT_GROUP format on inherited events being allowed
in kernel, we can now allow leader sampling on inherited events.
But before we actually switch it on, we need to change the sorting
of PERF_SAMPLE_READ sample's data. Currently PERF_SAMPLE_READ values
are sorted on event id. Now when we'll get data from all children
processes we need to add TID as another sort key.
Adding hash of TIDs into each 'struct perf_sample_id' to
hold event values for different TIDs.
Reported-by: Jen-Cheng(Tommy) Huang <tommy24@...ech.edu>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
Cc: David Ahern <dsahern@...il.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Jen-Cheng(Tommy) Huang <tommy24@...ech.edu>
Cc: Namhyung Kim <namhyung@...nel.org>
Cc: Paul Mackerras <paulus@...ba.org>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Stephane Eranian <eranian@...gle.com>
Signed-off-by: Jiri Olsa <jolsa@...nel.org>
---
tools/perf/util/evsel.c | 13 +++++++
tools/perf/util/evsel.h | 5 ++-
tools/perf/util/session.c | 93 ++++++++++++++++++++++++++++++++++++++++++++---
3 files changed, 104 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index b38de5819323..507d458ded2c 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -787,8 +787,21 @@ void perf_evsel__free_fd(struct perf_evsel *evsel)
evsel->fd = NULL;
}
+static void free_sample_id(struct perf_evsel *evsel)
+{
+ struct perf_sample_id *sid;
+
+ if (evsel->sample_id) {
+ xyarray__for_each(evsel->sample_id, sid) {
+ if (sid->periods)
+ perf_sample_hash__delete(sid->periods);
+ }
+ }
+}
+
void perf_evsel__free_id(struct perf_evsel *evsel)
{
+ free_sample_id(evsel);
xyarray__delete(evsel->sample_id);
evsel->sample_id = NULL;
zfree(&evsel->id);
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index 7bc314be6a7b..41c000fc018b 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -29,6 +29,7 @@ struct perf_counts {
};
struct perf_evsel;
+struct perf_sample_hash;
/*
* Per fd, to map back from PERF_SAMPLE_ID to evsel, only used when there are
@@ -40,9 +41,11 @@ struct perf_sample_id {
struct perf_evsel *evsel;
/* Holds total ID period value for PERF_SAMPLE_READ processing. */
- u64 period;
+ struct perf_sample_hash *periods;
};
+void perf_sample_hash__delete(struct perf_sample_hash *hash);
+
/** struct perf_evsel - event selector
*
* @name - Can be set to retain the original event name passed by the user,
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 6d2d50dea1d8..dcd2662b3b2e 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1,4 +1,6 @@
#include <linux/kernel.h>
+#include <linux/bitops.h>
+#include <linux/hash.h>
#include <traceevent/event-parse.h>
#include <byteswap.h>
@@ -733,6 +735,82 @@ static struct machine *
return &session->machines.host;
}
+struct perf_sample_period {
+ struct hlist_node node;
+ u64 value;
+ pid_t tid;
+};
+
+#define PERF_SAMPLE__HLIST_BITS 8
+#define PERF_SAMPLE__HLIST_SIZE (1 << PERF_SAMPLE__HLIST_BITS)
+
+struct perf_sample_hash {
+ struct hlist_head heads[PERF_SAMPLE__HLIST_SIZE];
+};
+
+void perf_sample_hash__delete(struct perf_sample_hash *hash)
+{
+ int h;
+
+ for (h = 0; h < PERF_SAMPLE__HLIST_SIZE; h++) {
+ struct perf_sample_period *period;
+ struct hlist_head *head;
+ struct hlist_node *n;
+
+ head = &hash->heads[h];
+ hlist_for_each_entry_safe(period, n, head, node) {
+ hlist_del(&period->node);
+ free(period);
+ }
+ }
+
+ free(hash);
+}
+
+static struct perf_sample_period*
+findnew_hash_period(struct perf_sample_hash *hash, pid_t tid)
+{
+ struct perf_sample_period *period;
+ struct hlist_head *head;
+ int hash_val;
+
+ hash_val = hash_64(tid, PERF_SAMPLE__HLIST_BITS);
+ head = &hash->heads[hash_val];
+
+ hlist_for_each_entry(period, head, node) {
+ if (period->tid == tid)
+ return period;
+ }
+
+ period = zalloc(sizeof(*period));
+ if (period) {
+ period->tid = tid;
+ hlist_add_head(&period->node, &hash->heads[hash_val]);
+ }
+
+ return period;
+}
+
+static struct perf_sample_period*
+get_sample_period(struct perf_sample_id *sid, pid_t tid)
+{
+ struct perf_sample_hash *hash = sid->periods;
+ int i;
+
+ if (hash == NULL) {
+ hash = zalloc(sizeof(*hash));
+ if (hash == NULL)
+ return NULL;
+
+ for (i = 0; i < PERF_SAMPLE__HLIST_SIZE; ++i)
+ INIT_HLIST_HEAD(&hash->heads[i]);
+
+ sid->periods = hash;
+ }
+
+ return findnew_hash_period(hash, tid);
+}
+
static int deliver_sample_value(struct perf_session *session,
struct perf_tool *tool,
union perf_event *event,
@@ -741,19 +819,22 @@ static int deliver_sample_value(struct perf_session *session,
struct machine *machine)
{
struct perf_sample_id *sid;
+ struct perf_sample_period *period;
sid = perf_evlist__id2sid(session->evlist, v->id);
- if (sid) {
- sample->id = v->id;
- sample->period = v->value - sid->period;
- sid->period = v->value;
- }
-
if (!sid || sid->evsel == NULL) {
++session->stats.nr_unknown_id;
return 0;
}
+ period = get_sample_period(sid, sample->tid);
+ if (period == NULL)
+ return -ENOMEM;
+
+ sample->id = v->id;
+ sample->period = v->value - period->value;
+ period->value = v->value;
+
return tool->sample(tool, event, sample, sid->evsel, machine);
}
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists