lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Aug 2014 16:18:40 +0300 From: Grazvydas Ignotas <notasas@...il.com> To: Tony Lindgren <tony@...mide.com> Cc: Kishon Vijay Abraham I <kishon@...com>, Felipe Balbi <balbi@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Linux USB Mailing List <linux-usb@...r.kernel.org>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org> Subject: Re: [PATCH] usb: phy: twl4030-usb: Fix lost interrupts after ID pin goes down Hi, On Thu, Aug 21, 2014 at 7:48 PM, Tony Lindgren <tony@...mide.com> wrote: > Commit 249751f22380 ("usb: phy: twl4030-usb: poll for ID disconnect") > added twl4030_id_workaround_work() to deal with lost interrupts > after ID pin goes down. However, this currently only works for the > insertion. The PHY interrupts are not working after disconnecting > an USB-A device from the board, and the deeper idle states for > omap are blocked as the USB controller stays busy. > > The issue can be solved by calling delayed work from twl4030_usb_irq() > when ID pin is down and the PHY is not asleep like we already do > in twl4030_id_workaround_work(). The way it is supposed to work is that after plugging in the cable twl4030_phy_power_on() sees ID_GROUND and kicks off id_workaround_work every second. When cable is unplugged, twl4030_id_workaround_work() sees changes in STS_HW_CONDITIONS register and triggers events. Doesn't that work for you, why do you need to trigger it from twl4030_usb_irq() too? > But as both twl4030_usb_irq() and twl4030_id_workaround_work() > already do pretty much the same thing, let's call twl4030_usb_irq() > from twl4030_id_workaround_work() instead of adding some more > duplicate code. The difference is the sysfs_notify() call, so now every time id_workaround_work triggers (around once per second while the cable is plugged) userspace will now get useless uevent. Haven't actually checked if it really happens though, so I might be wrong. -- GraÅžvydas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists