linux-kernel - Re: Trickle charging for rtc-bq32k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140822142852.GA1545@katana>
Date:	Fri, 22 Aug 2014 09:28:52 -0500
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Pavel Machek <pavel@....cz>
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org
Subject: Re: Trickle charging for rtc-bq32k

> _But_ this should probably be enabled using device tree entry, right?
> Unfortunately, the driver is i2c driver, not platform one, so I don't
> see how to do that easily...

Trickle charging is usually depending on the hardware setup, so
devicetree is actually a good place to put it. We'd just need generic
bindings so that they could be applied to various RTC. Just guessing,
resistor value would probably be one such property? We would not need
putting plain register values into DT.

There should be no difference regarding DT between i2c and platform
drivers.

You should add the devicetree ML for discussing such things.

> Or would module parameter be acceptable?

No, this is device dependent, not module dependent.

>   * Copyright (C) 2009 Semihalf.
> + * Copyright (C) 2014 Pavel Machek <pavel@...x.de>

IMO, such a small improvement does not justify claiming copyright on the
driver.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)