linux-kernel - RE: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37724B2049F71D4C9B086F99DDB2DE11572409D6@CMEXMB2.ad.emulex.com>
Date:	Fri, 22 Aug 2014 14:40:25 +0000
From:	Jayamohan Kallickal <Jayamohan.Kallickal@...lex.Com>
To:	Tomas Henzl <thenzl@...hat.com>,
	Alexander Gordeev <agordeev@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()



-----Original Message-----
From: Tomas Henzl [mailto:thenzl@...hat.com] 
Sent: Thursday, August 21, 2014 4:10 AM
To: Alexander Gordeev; linux-kernel@...r.kernel.org
Cc: Jayamohan Kallickal; linux-scsi@...r.kernel.org; linux-pci@...r.kernel.org
Subject: Re: [PATCH v3 08/13] be2iscsi: Use pci_enable_msix_range()

On 08/18/2014 08:01 AM, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers using these 
> two interfaces need to be updated to use the new 
> pci_enable_msi_range() and pci_enable_msix_range() interfaces.

Patch looks good to me.

Reviewed-by: Tomas Henzl <thenzl@...hat.com>

> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> Cc: Jayamohan Kallickal <jayamohan.kallickal@...lex.com>
> Cc: linux-scsi@...r.kernel.org
> Cc: linux-pci@...r.kernel.org
> ---
>  drivers/scsi/be2iscsi/be_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c 
> b/drivers/scsi/be2iscsi/be_main.c index 915c26b..b422659 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -5276,9 +5276,9 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba)
>  	for (i = 0; i <= phba->num_cpus; i++)
>  		phba->msix_entries[i].entry = i;
>  
> -	status = pci_enable_msix(phba->pcidev, phba->msix_entries,
> -				 (phba->num_cpus + 1));
> -	if (!status)
> +	status = pci_enable_msix_range(phba->pcidev, phba->msix_entries,
> +				       phba->num_cpus + 1, phba->num_cpus + 1);
> +	if (status > 0)
>  		phba->msix_enabled = true;
>  
>  	return;


Looks Good.

Acked-by:  Jayamohan Kallickal <jayamohan.kallickal@...lex.com>
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/