linux-kernel - Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49DF2059@DFLE09.ent.ti.com>
Date:	Fri, 22 Aug 2014 14:49:52 +0000
From:	"Murphy, Dan" <dmurphy@...com>
To:	"Balbi, Felipe" <balbi@...com>
CC:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document

Felipe

On 08/22/2014 09:45 AM, Balbi, Felipe wrote:
> Hi,
> 
> On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
>> Felipe
>>
>> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
>>> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
>>>> Update the drv260x dt binding document:
>>>> - Change the node name to the devices function not the
>>>> device name.
>>>> - Add vbat-supply to the example.
>>>> - Fix indentation of the example.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@...com>
>>>> ---
>>>>  .../devicetree/bindings/input/ti,drv260x.txt       |   19 ++++++++++---------
>>>>  1 file changed, 10 insertions(+), 9 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> index a9c8519..214e25d 100644
>>>> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> @@ -37,15 +37,16 @@ Optional properties:
>>>>  			  3.2 v.
>>>>  Example:
>>>>  
>>>> -drv2605l: drv2605l@5a {
>>>> -		compatible = "ti,drv2605l";
>>>> -		reg = <0x5a>;
>>>> -		enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>>> -		mode = <DRV260X_LRA_MODE>;
>>>> -		library-sel = <DRV260X_LIB_LRA>;
>>>> -		vib-rated-mv = <3200>;
>>>> -		vib-overdriver-mv = <3200>;
>>>> -};
>>>> +haptics:@5a {
>>>
>>> haptics: haptics@5a ??
>>>
>>
>> I found both types of entries in the bindings docs.
>> There is no consistency within the input bindings documentation.
> 
> I could swear neither two types have a colon character between node name
> and its base address.
> 

I will add it to the fixes.

Dan

-- 
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/