linux-kernel - Re: [PATCH v2] drivers: usb: gadget: fusb300

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140822155809.GA27616@saruman.home>
Date:	Fri, 22 Aug 2014 10:58:09 -0500
From:	Felipe Balbi <balbi@...com>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
CC:	<balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drivers: usb: gadget: fusb300_udc.h: Fix typo in
 include guard

Hi,

On Fri, Aug 22, 2014 at 05:21:12PM +0200, Rasmus Villemoes wrote:
> Felipe Balbi <balbi@...com> writes:
> 
> > On Fri, Aug 22, 2014 at 04:44:33PM +0200, Rasmus Villemoes wrote:
> >> Clearly this was meant to be an include guard, but a trailing
> >> underscore was missing. It has been this way since the file was
> >> introduced in 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver").
> >> 
> >
> > right here you need to have:
> >
> > Fixes: 0fe6f1d1 ("usb: udc: add Faraday fusb300 driver")
> > Cc: <stable@...r.kernel.org>
> 
> Really? I can't see that it satisfies the
> Documentation/stable_kernel_rules.txt. There's no chance of build error, since the
> file is only included directly from a single .c file. As you can see on
> LKML I've sent a few handfuls of similar patches all over the tree; IMHO
> none of them qualify for stable.
> 
> If you insist, I'll add the Fixes and Cc tags.

it's a bug fix nevertheless.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)