[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1408726332.13483.25.camel@joe-AO725>
Date: Fri, 22 Aug 2014 09:52:12 -0700
From: Joe Perches <joe@...ches.com>
To: Andy Lutomirski <luto@...capital.net>
Cc: "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>,
Andy Whitcroft <apw@...onical.com>,
Arnd Bergmann <arnd@...db.de>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] errno.h: Improve ENOSYS's comment
On Fri, 2014-08-22 at 09:30 -0700, Andy Lutomirski wrote:
> ENOSYS is the mechanism used by user code to detect whether the
> running kernel implements a given system call. It should not be
> returned by anything except an unimplemented system call.
>
> Unfortunately, it is rather frequently used in the kernel to
> indicate that various new functions of existing system calls are not
> implemented. This should be discouraged.
>
> Improve the command in errno.h to help clarify ENOSYS's purpose.
[]
> diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h
[]
> @@ -6,7 +6,7 @@
[]
> -#define ENOSYS 38 /* Function not implemented */
> +#define ENOSYS 38 /* Bad system call number */
I suggest "Invalid" rather than "Bad".
Maybe also add something like:
/* see: man 2 syscalls */
or
/* grep for SYSCALL_DEFINE */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists