linux-kernel - Re: [PATCH] drivers: staging: rtl8723au: Fix "(foo*)" should be "(foo *)" errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 11:10:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg Donald <gdonald@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...ux.com>,
	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8723au: Fix "(foo*)" should be
 "(foo *)" errors

On Fri, 2014-08-22 at 12:20 -0500, Greg Donald wrote:
> Fix checkpatch.pl "(foo*)" should be "(foo *)" errors

Hello Greg.

> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
[]
> @@ -599,7 +599,7 @@ void update_sta_info23a_apmode23a(struct rtw_adapter *padapter, struct sta_info
>  
>  	/* todo: init other variables */
>  
> -	memset((void*)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
> +	memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));

It'd be better to remove the (void *) cast instead.

[]
> diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
[]
> @@ -1493,7 +1493,7 @@ void rtw_setstaKey_cmdrsp_callback23a(struct rtw_adapter *padapter,
>  	struct sta_info *psta;
>  
>  	pstapriv = &padapter->stapriv;
> -	psetstakey_rsp = (struct set_stakey_rsp*) (pcmd->rsp);
> +	psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);

Probably better to remove the space and the
unnecessary parentheses:

	psetstakey_rsp = (struct set_stakey_rsp *)pcmd->rsp;

> @@ -1518,7 +1518,7 @@ void rtw_setassocsta_cmdrsp_callback23a(struct rtw_adapter *padapter,
>  	struct sta_info *psta;
>  
>  	passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
> -	passocsta_rsp = (struct set_assocsta_rsp*) (pcmd->rsp);
> +	passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);

same unnecessary parentheses, maybe
submit separate patches for those.

> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
[]
> @@ -4763,7 +4763,7 @@ void report_survey_event23a(struct rtw_adapter *padapter,
>  	pcmd_obj->rsp = NULL;
>  	pcmd_obj->rspsz  = 0;
>  
> -	pc2h_evt_hdr = (struct C2HEvent_Header*)(pevtcmd);
> +	pc2h_evt_hdr = (struct C2HEvent_Header *)(pevtcmd);

more unnecessary parentheses, etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/