linux-kernel - Re: [PATCH] trace-cmd: link trace-record in ctracecmd.so

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140822170535.52f12438@gandalf.local.home>
Date:	Fri, 22 Aug 2014 17:05:35 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Javi Merino" <javi.merino@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace-cmd: link trace-record in ctracecmd.so

On Fri, 15 Aug 2014 16:31:38 +0100
"Javi Merino" <javi.merino@....com> wrote:

> Commit b1e9220819eb (trace-cmd: Report stats for all instances) moved
> tracecmd_stat_cpu() from trace-recorder.c to trace-record.c.  This
> makes import ctracecmd fail in tracecmd.py:
> 
> $ python tracecmd.py
> Traceback (most recent call last):
>   File "tracecmd.py", line 22, in <module>
>     from ctracecmd import *
> ImportError: ctracecmd.so: undefined symbol: tracecmd_stat_cpu
> 
> Link trace-record in ctracecmd.so to add back the required symbol.
> 

I just applied this. May push this out next week. I have other changes
I'm adding and need to get them finished before I push it out. It may
not go out until September though.

-- Steve

> Signed-off-by: Javi Merino <javi.merino@....com>
> ---
>  Makefile | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index cbe0eb9..308d7f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -317,8 +317,9 @@ KERNEL_SHARK_OBJS = $(TRACE_VIEW_OBJS) $(TRACE_GRAPH_OBJS) $(TRACE_GUI_OBJS) \
>  
>  PEVENT_LIB_OBJS = event-parse.o trace-seq.o parse-filter.o parse-utils.o
>  TCMD_LIB_OBJS = $(PEVENT_LIB_OBJS) trace-util.o trace-input.o trace-ftrace.o \
> -			trace-output.o trace-recorder.o trace-restore.o trace-usage.o \
> -			trace-blk-hack.o kbuffer-parse.o event-plugin.o
> +			trace-output.o trace-record.o trace-recorder.o \
> +			trace-restore.o trace-usage.o trace-blk-hack.o \
> +			kbuffer-parse.o event-plugin.o
>  
>  PLUGIN_OBJS =
>  PLUGIN_OBJS += plugin_jbd2.o

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/