linux-kernel - Re: [PATCH] tcm_fc: Replace rcu_assign_pointer() with RCU_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 14:10:38 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Andreea-Cristina Bernat <bernat.ada@...il.com>
Cc:	agrover@...hat.com, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] tcm_fc: Replace rcu_assign_pointer() with
 RCU_INIT_POINTER()

Hi Andreea-Cristina,

On Mon, 2014-08-18 at 15:05 +0300, Andreea-Cristina Bernat wrote:
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it instead of rcu_assign_pointer() because it has a
> smaller overhead.
> 
> The following Coccinelle semantic patch was used:
> @@
> @@
> 
> - rcu_assign_pointer
> + RCU_INIT_POINTER
>   (..., NULL)
> 
> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@...il.com>
> ---
>  drivers/target/tcm_fc/tfc_sess.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
> index 21ce508..ccee7e3 100644
> --- a/drivers/target/tcm_fc/tfc_sess.c
> +++ b/drivers/target/tcm_fc/tfc_sess.c
> @@ -98,7 +98,7 @@ static void ft_tport_delete(struct ft_tport *tport)
>  	ft_sess_delete_all(tport);
>  	lport = tport->lport;
>  	BUG_ON(tport != lport->prov[FC_TYPE_FCP]);
> -	rcu_assign_pointer(lport->prov[FC_TYPE_FCP], NULL);
> +	RCU_INIT_POINTER(lport->prov[FC_TYPE_FCP], NULL);
>  
>  	tpg = tport->tpg;
>  	if (tpg) {

Applied to target-pending.git.

Thanks!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/