linux-kernel - Re: [PATCH v2 1/2] pmbus: add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140822214417.GC24407@sirena.org.uk>
Date:	Fri, 22 Aug 2014 16:44:17 -0500
From:	Mark Brown <broonie@...nel.org>
To:	atull@...nsource.altera.com
Cc:	linux@...ck-us.net, jdelvare@...e.de, lm-sensors@...sensors.org,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	delicious.quinoa@...il.com, dinguyen@...nsource.altera.com,
	yvanderv@...nsource.altera.com
Subject: Re: [PATCH v2 1/2] pmbus: add regulator support

On Fri, Aug 22, 2014 at 04:11:33PM -0500, atull@...nsource.altera.com wrote:

> +	if (pdata && pdata->reg_init_data) {
> +		config.init_data = pdata->reg_init_data;
> +	} else {
> +		config.init_data = of_get_regulator_init_data(dev, np);
> +		if (!config.init_data)
> +			return -ENOMEM;
> +	}

It should be fine to start with no init data - just let the regulator
core worry about it.  This will allow users to read back the state even
if they can't change anything which is useful for system bringup or
general debugging.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)