linux-kernel - Re: [PATCH] backlight: platform_lcd: remove unnecessary #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2014 09:13:23 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>, Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] backlight: platform_lcd: remove unnecessary #ifdef CONFIG_OF

On Fri, Aug 22, 2014 at 8:23 AM, Jingoo Han <jg1.han@...sung.com> wrote:
> Remove unnecessary #ifdef CONFIG_OF, because this is already
> handled by the of_match_ptr macro.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/video/backlight/platform_lcd.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c
> index c3d2e209fc8f..2bca5ca760ee 100644
> --- a/drivers/video/backlight/platform_lcd.c
> +++ b/drivers/video/backlight/platform_lcd.c
> @@ -137,13 +137,11 @@ static int platform_lcd_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
>                         platform_lcd_resume);
>
> -#ifdef CONFIG_OF
>  static const struct of_device_id platform_lcd_of_match[] = {
>         { .compatible = "platform-lcd" },
>         {},
>  };
>  MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
> -#endif
>
>  static struct platform_driver platform_lcd_driver = {
>         .driver         = {

Doesn't this introduce a compiler warning ("defined but not used") if
CONFIG_OF is not set?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/